richardstartin commented on a change in pull request #7927:
URL: https://github.com/apache/pinot/pull/7927#discussion_r772832180
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java
##########
@@ -82,6 +88,13 @@ default StreamPartitionMsgOffset
getNextStreamParitionMsgOffsetAtIndex(int index
return new LongMsgOffset(getNextStreamMessageOffsetAtIndex(index));
}
+ /**
+ * @return last offset in the batch
+ */
+ default StreamPartitionMsgOffset getLastOffset() {
+ return getNextStreamParitionMsgOffsetAtIndex(getMessageCount() - 1);
Review comment:
Indeed, `getMessageCount() - 1` is not an offset, but an index into the
batch of messages - it returns the next offset of the last message.
`getNextStreamParitionMsgOffsetAtIndex` takes an _index_ and produces the next
offset from the message at that index. Does this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
