Jackie-Jiang commented on a change in pull request #7949:
URL: https://github.com/apache/pinot/pull/7949#discussion_r774812191
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##########
@@ -257,19 +257,46 @@ public int getNumKeys() {
@Override
public void processSingleValue(int numDocs, int[] outGroupIds) {
- if (_numGroupByExpressions == 1) {
- processSingleValue(numDocs, _singleValueDictIds[0], outGroupIds);
- } else {
- processSingleValueGeneric(numDocs, outGroupIds);
+ switch (_numGroupByExpressions) {
+ case 1:
+ processSingleValue(numDocs, _singleValueDictIds[0], outGroupIds);
+ return;
+ case 2:
+ processSingleValue(numDocs, _singleValueDictIds[0],
_singleValueDictIds[1], outGroupIds);
+ return;
+ case 3:
+ processSingleValue(numDocs, _singleValueDictIds[0],
_singleValueDictIds[1], _singleValueDictIds[2],
+ outGroupIds);
+ return;
+ default:
}
+ processSingleValueGeneric(numDocs, outGroupIds);
}
private void processSingleValue(int numDocs, int[] dictIds, int[]
outGroupIds) {
System.arraycopy(dictIds, 0, outGroupIds, 0, numDocs);
+ markGroups(numDocs, outGroupIds);
+ }
+
+ private void processSingleValue(int numDocs, int[] dictIds0, int[]
dictIds1, int[] outGroupIds) {
+ for (int i = 0; i < numDocs; i++) {
+ outGroupIds[i] = dictIds1[i] * _cardinalities[0] + dictIds0[i];
+ }
+ markGroups(numDocs, outGroupIds);
+ }
+
+ private void processSingleValue(int numDocs, int[] dictIds0, int[]
dictIds1, int[] dicIds2, int[] outGroupIds) {
Review comment:
(minor)
```suggestion
private void processSingleValue(int numDocs, int[] dictIds0, int[]
dictIds1, int[] dictIds2, int[] outGroupIds) {
```
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##########
@@ -257,19 +257,46 @@ public int getNumKeys() {
@Override
public void processSingleValue(int numDocs, int[] outGroupIds) {
- if (_numGroupByExpressions == 1) {
- processSingleValue(numDocs, _singleValueDictIds[0], outGroupIds);
- } else {
- processSingleValueGeneric(numDocs, outGroupIds);
+ switch (_numGroupByExpressions) {
+ case 1:
+ processSingleValue(numDocs, _singleValueDictIds[0], outGroupIds);
+ return;
+ case 2:
+ processSingleValue(numDocs, _singleValueDictIds[0],
_singleValueDictIds[1], outGroupIds);
+ return;
+ case 3:
+ processSingleValue(numDocs, _singleValueDictIds[0],
_singleValueDictIds[1], _singleValueDictIds[2],
+ outGroupIds);
+ return;
+ default:
}
+ processSingleValueGeneric(numDocs, outGroupIds);
}
private void processSingleValue(int numDocs, int[] dictIds, int[]
outGroupIds) {
System.arraycopy(dictIds, 0, outGroupIds, 0, numDocs);
+ markGroups(numDocs, outGroupIds);
+ }
+
+ private void processSingleValue(int numDocs, int[] dictIds0, int[]
dictIds1, int[] outGroupIds) {
+ for (int i = 0; i < numDocs; i++) {
+ outGroupIds[i] = dictIds1[i] * _cardinalities[0] + dictIds0[i];
+ }
+ markGroups(numDocs, outGroupIds);
+ }
+
+ private void processSingleValue(int numDocs, int[] dictIds0, int[]
dictIds1, int[] dicIds2, int[] outGroupIds) {
+ for (int i = 0; i < numDocs; i++) {
+ outGroupIds[i] = (dicIds2[i] * _cardinalities[1] + dictIds1[i]) *
_cardinalities[0] + dictIds0[i];
Review comment:
Will it be faster if we precompute `_cardinalities[1] *
_cardinalities[0]`, and use `dictIds2[i] * precomputedCardinality + dictIds1[i]
* _cardinalities[0] + dictIds0[i]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
