Jackie-Jiang commented on a change in pull request #7920:
URL: https://github.com/apache/pinot/pull/7920#discussion_r774819977
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java
##########
@@ -48,6 +52,175 @@ public ChunkReaderContext createContext() {
}
}
+ @Override
+ public void readValuesSV(int[] docIds, int length, int[] values,
ChunkReaderContext context) {
+ if (getValueType().getStoredType().isFixedWidth() && !_isCompressed &&
isContiguousRange(docIds, length)) {
+ switch (getValueType().getStoredType()) {
Review comment:
(minor)
`getStoredType()` is redundant because value type is stored type for forward
index. Same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
