suddendust commented on a change in pull request #7893:
URL: https://github.com/apache/pinot/pull/7893#discussion_r774884333
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
##########
@@ -212,33 +218,45 @@ public void reloadSegment(String tableNameWithType,
String segmentName, boolean
}
@Override
- public void reloadAllSegments(String tableNameWithType, boolean
forceDownload) {
+ public void reloadAllSegments(String tableNameWithType, boolean
forceDownload,
+ SegmentRefreshSemaphore segmentRefreshSemaphore)
+ throws Exception {
LOGGER.info("Reloading all segments in table: {}", tableNameWithType);
TableConfig tableConfig =
ZKMetadataProvider.getTableConfig(_propertyStore, tableNameWithType);
Preconditions.checkNotNull(tableConfig);
-
Schema schema = ZKMetadataProvider.getTableSchema(_propertyStore,
tableNameWithType);
-
List<String> failedSegments = new ArrayList<>();
- Exception sampleException = null;
List<SegmentMetadata> segmentsMetadata =
getAllSegmentsMetadata(tableNameWithType);
- for (SegmentMetadata segmentMetadata : segmentsMetadata) {
+ ExecutorService workers = Executors.newCachedThreadPool();
+ final AtomicReference<Exception> sampleException = new AtomicReference<>();
+ //calling thread hasn't acquired any permit so we don't reload any
segments using it.
+ CompletableFuture.allOf(segmentsMetadata.stream().map(segmentMetadata ->
CompletableFuture.runAsync(() -> {
+ String segmentName = segmentMetadata.getName();
try {
- reloadSegment(tableNameWithType, segmentMetadata, tableConfig, schema,
forceDownload);
+ segmentRefreshSemaphore.acquireSema(segmentMetadata.getName(), LOGGER);
+ try {
+ reloadSegment(tableNameWithType, segmentMetadata, tableConfig,
schema, forceDownload);
+ } catch (Exception e) {
+ LOGGER.error("Caught exception while reloading segment: {} in table:
{}", segmentName, tableNameWithType, e);
+ failedSegments.add(segmentName);
+ sampleException.set(e);
Review comment:
The outside `try-catch` is to handle any `InterruptedException` while
trying to acquire a permit (`acquireSema` throws an `InterruptedException`). If
we put a `finally` in that block it'll try to release a permit in this case
which would be wrong. So we need to another `try-catch` inside the outer `try`
to execute the `finally`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
