jackjlli commented on a change in pull request #7961:
URL: https://github.com/apache/pinot/pull/7961#discussion_r778344805
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java
##########
@@ -374,6 +423,15 @@ public void start()
LOGGER.info("Starting Pinot server");
long startTimeMs = System.currentTimeMillis();
+ if (_serverConf.getProperty(Server.CONFIG_OF_STARTUP_ENABLE_TEMP_CLEANUP,
+ Server.DEFAULT_STARTUP_ENABLE_TEMP_CLEANUP)) {
+ File dataDir = new
File(_serverConf.getProperty(CommonConstants.Server.CONFIG_OF_INSTANCE_DATA_DIR));
+ // We use 3 hours as the cutoff time as a general heuristic for when
Review comment:
It'd be great to add more details on the purpose of introducing this
threshold in the comment, like what we discuss in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
