klsince commented on a change in pull request #7969:
URL: https://github.com/apache/pinot/pull/7969#discussion_r782517157
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/store/SegmentDirectory.java
##########
@@ -140,6 +141,14 @@ public void acquire(FetchContext fetchContext) {
public void release(FetchContext fetchContext) {
}
+ /**
+ * Copy segment directory to a local directory.
+ * @param dest the destination directory
+ */
+ public void copyTo(File dest)
Review comment:
I'd prefer copyTo as it doesn't imply where the source is. copyToLoca()
kinda implies the source is remote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
