jackjlli commented on a change in pull request #8004:
URL: https://github.com/apache/pinot/pull/8004#discussion_r783343221
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
##########
@@ -232,26 +232,27 @@ public void start()
boolean caseInsensitive =
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, false) ||
_brokerConf.getProperty(
Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, false);
- TableCache tableCache = new TableCache(_propertyStore, caseInsensitive);
+ DefaultPinotConfigProvider defaultPinotConfigProvider =
Review comment:
Probably use `PinotConfigProvider` as the reference here since we've
already declared all the essential methods to the interface? Also change the
variable name to `pinotConfigProvider`.
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -111,7 +111,7 @@
protected final RoutingManager _routingManager;
protected final AccessControlFactory _accessControlFactory;
protected final QueryQuotaManager _queryQuotaManager;
- protected final TableCache _tableCache;
+ protected final DefaultPinotConfigProvider _defaultPinotConfigProvider;
Review comment:
Use `PinotConfigProvider` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
