jackjlli commented on a change in pull request #7995:
URL: https://github.com/apache/pinot/pull/7995#discussion_r783609349
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/retention/SegmentLineageCleanupTest.java
##########
@@ -168,15 +175,60 @@ public void testSegmentLineageCleanup()
segmentsForTable =
ControllerTestUtils.getHelixResourceManager().getSegmentsFor(OFFLINE_TABLE_NAME,
false);
Assert.assertEquals(segmentsForTable.size(), 3);
Assert.assertTrue(Collections.disjoint(segmentsForTable,
Arrays.asList("merged_1", "merged_2")));
- segmentLineage =
- SegmentLineageAccessHelper
-
.getSegmentLineage(ControllerTestUtils.getHelixResourceManager().getPropertyStore(),
OFFLINE_TABLE_NAME);
+ segmentLineage = SegmentLineageAccessHelper
+
.getSegmentLineage(ControllerTestUtils.getHelixResourceManager().getPropertyStore(),
OFFLINE_TABLE_NAME);
Assert.assertEquals(segmentLineage.getLineageEntryIds().size(), 1);
}
+ @Test
+ public void testRefreshTableCleanup()
+ throws InterruptedException {
+ // Create metadata for original segments
+ for (int i = 0; i < 3; i++) {
+
ControllerTestUtils.getHelixResourceManager().addNewSegment(REFRESH_OFFLINE_TABLE_NAME,
+
SegmentMetadataMockUtils.mockSegmentMetadata(REFRESH_OFFLINE_TABLE_NAME,
"segment1_" + i), "downloadUrl");
+ }
+
+ // Create metadata for new segments.
+ for (int i = 0; i < 3; i++) {
+
ControllerTestUtils.getHelixResourceManager().addNewSegment(REFRESH_OFFLINE_TABLE_NAME,
+
SegmentMetadataMockUtils.mockSegmentMetadata(REFRESH_OFFLINE_TABLE_NAME,
"segment2_" + i), "downloadUrl");
+ }
+
+ Assert.assertEquals(
+
ControllerTestUtils.getHelixResourceManager().getSegmentsFor(REFRESH_OFFLINE_TABLE_NAME,
false).size(), 6);
+
+ // Validate the case when the lineage entry state is 'IN_PROGRESS'
+ SegmentLineage segmentLineage = new
SegmentLineage(REFRESH_OFFLINE_TABLE_NAME);
+ segmentLineage.addLineageEntry("0", new
LineageEntry(Arrays.asList("segment1_0", "segment1_1", "segment1_2"),
+ Arrays.asList("segment2_0", "segment2_1", "segment2_2"),
LineageEntryState.IN_PROGRESS,
+ System.currentTimeMillis()));
+ SegmentLineageAccessHelper
+
.writeSegmentLineage(ControllerTestUtils.getHelixResourceManager().getPropertyStore(),
segmentLineage, -1);
+ _retentionManager.processTable(REFRESH_OFFLINE_TABLE_NAME);
+ try {
+ waitForSegmentsToDelete(REFRESH_OFFLINE_TABLE_NAME, 3, 1000L);
Review comment:
Setting the 3rd param to 1000L means the validation will only be done at
most 2 times ( probably just 1 time in limited resources). The default 10
seconds doesn't mean it always wait for 10 seconds. But I'm fine with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
