mneedham commented on a change in pull request #8001:
URL: https://github.com/apache/pinot/pull/8001#discussion_r784970032
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/StAreaFunction.java
##########
@@ -62,8 +63,8 @@ public void init(List<TransformFunction> arguments,
Map<String, DataSource> data
TransformFunction transformFunction = arguments.get(0);
Preconditions.checkArgument(transformFunction.getResultMetadata().isSingleValue(),
"Argument must be single-valued for transform function: %s",
getName());
-
Preconditions.checkArgument(transformFunction.getResultMetadata().getDataType()
== FieldSpec.DataType.BYTES,
- "The argument must be of bytes type");
+
Preconditions.checkArgument(transformFunction.getResultMetadata().getDataType()
== FieldSpec.DataType.BYTES
+ || transformFunction instanceof LiteralTransformFunction,
notBytesErrorMessage(transformFunction));
Review comment:
@walterddr yeh this is a good question! But all the existing ST_*
functions do it like this and it seems to work alright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
