xiangfu0 commented on a change in pull request #8028: URL: https://github.com/apache/pinot/pull/8028#discussion_r785185137
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java ########## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.minion.generator; + +import org.apache.helix.task.JobConfig; +import org.apache.pinot.controller.helix.core.minion.ClusterInfoAccessor; +import org.apache.pinot.core.common.MinionConstants; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Base implementation of the {@link PinotTaskGenerator} which reads the 'taskTimeoutMs' and + * 'numConcurrentTasksPerInstance' from the cluster config. + */ +public abstract class BaseTaskGenerator implements PinotTaskGenerator { + protected static final Logger LOGGER = LoggerFactory.getLogger(BaseTaskGenerator.class); + + protected ClusterInfoAccessor _clusterInfoAccessor; + + @Override + public void init(ClusterInfoAccessor clusterInfoAccessor) { + _clusterInfoAccessor = clusterInfoAccessor; + } + + @Override + public long getTaskTimeoutMs() { + String taskType = getTaskType(); + String configKey = taskType + MinionConstants.TIMEOUT_MS_KEY_SUFFIX; Review comment: make a static util method like getclusterConfigs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
