richardstartin commented on pull request #8057: URL: https://github.com/apache/pinot/pull/8057#issuecomment-1019933247
hi @kriti-sc could you cover this with some tests please? I would want to see both: * Unit tests at the Kafka consumer level e.g. the correct offsets are produced from a given timestamp, mocking the `Consumer` * An integration test involving `LLRealtimeSegmentDataManager` with `TIMESTAMP` offset type. I recently had to fix a bug where realtime ingestion stalled indefinitely, which was caused by a very simple change to Kafka stream consumption, so going forwards I would like to see proof that `LLRealtimeSegmentDataManager#consumeLoop` can advance whenever a newly introduced branch/setting is active. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
