walterddr commented on a change in pull request #8080:
URL: https://github.com/apache/pinot/pull/8080#discussion_r794195467



##########
File path: pinot-common/src/test/resources/schemaTest.schema
##########
@@ -88,6 +88,12 @@
       "format": "1:DAYS:SIMPLE_DATE_FORMAT:yyyyMMdd",
       "granularity": "1:DAYS",
       "defaultNullValue": "20200101"
+    },
+    {
+      "name": "dateTime3",
+      "dataType": "TIMESTAMP",
+      "format": "1:MILLISECONDS:TIMESTAMP",

Review comment:
       Just checked a community discussion that this can only be TIMESTAMP and 
setting the format to 
   `1:MILLISECONDS:EPOCH` will fail. 
   
   Is there a reason why? I think we should support both. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to