mqliang commented on a change in pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#discussion_r796067442
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerFactory.java
##########
@@ -45,30 +50,41 @@ private SegmentPrunerFactory() {
public static List<SegmentPruner> getSegmentPruners(TableConfig tableConfig,
ZkHelixPropertyStore<ZNRecord> propertyStore) {
- RoutingConfig routingConfig = tableConfig.getRoutingConfig();
List<SegmentPruner> segmentPruners = new ArrayList<>();
- // Always prune out empty segments first
- segmentPruners.add(new EmptySegmentPruner(tableConfig, propertyStore));
+ boolean isKinesisEnabled = isKinesisEnabled(tableConfig);
Review comment:
cc @snleee There are two TableConfigUtils,
```
org.apache.pinot.segment.local.utils.TableConfigUtils;
org.apache.pinot.common.utils.config.TableConfigUtils;
```
* If we put the `needsEmptySegmentPruner ` function in
`org.apache.pinot.segment.local.utils.TableConfigUtils;`, then we need add
`pinot-kinesis` dependency to package `pinot-segment-local`
* If we put the `needsEmptySegmentPruner ` function in
`org.apache.pinot.common.utils.config.TableConfigUtils`, then we need add
`pinot-kinesis` dependency to package `pinot-common`
kinesis plugin dependency will not been added to pinot-broker, but must be
add to either `pinot-segment-local` or `pinot-common`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
