Jackie-Jiang commented on a change in pull request #8109:
URL: https://github.com/apache/pinot/pull/8109#discussion_r797849666
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
##########
@@ -453,10 +453,16 @@ private CommonConstants() {
public static final String DEFAULT_INSTANCE_BASE_DIR =
System.getProperty("java.io.tmpdir") + File.separator + "PinotMinion";
public static final String DEFAULT_INSTANCE_DATA_DIR =
DEFAULT_INSTANCE_BASE_DIR + File.separator + "data";
- public static final String PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY =
"storage.factory";
- public static final String PREFIX_OF_CONFIG_OF_SEGMENT_FETCHER_FACTORY =
"segment.fetcher";
- public static final String PREFIX_OF_CONFIG_OF_SEGMENT_UPLOADER =
"segment.uploader";
- public static final String PREFIX_OF_CONFIG_OF_PINOT_CRYPTER = "crypter";
+
+ // Add pinot.minion prefix on those configs to be consistent with configs
of controller and server.
+ public static final String PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY =
"pinot.minion.storage.factory";
+ public static final String PREFIX_OF_CONFIG_OF_SEGMENT_FETCHER_FACTORY =
"pinot.minion.segment.fetcher";
+ public static final String PREFIX_OF_CONFIG_OF_SEGMENT_UPLOADER =
"pinot.minion.segment.uploader";
+ public static final String PREFIX_OF_CONFIG_OF_PINOT_CRYPTER =
"pinot.minion.crypter";
+ public static final String DEPRECATED_PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY
= "storage.factory";
Review comment:
Please add deprecated annotation to these keys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
