Jackie-Jiang commented on a change in pull request #8112:
URL: https://github.com/apache/pinot/pull/8112#discussion_r798266012
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java
##########
@@ -105,9 +106,11 @@ public static InstanceAssignmentConfig
getInstanceAssignmentConfig(TableConfig t
int numReplicaGroups = segmentConfig.getReplicationNumber();
ReplicaGroupStrategyConfig replicaGroupStrategyConfig =
segmentConfig.getReplicaGroupStrategyConfig();
Preconditions.checkState(replicaGroupStrategyConfig != null, "Failed to
find the replica-group strategy config");
+ SegmentPartitionConfig segmentPartitionConfig =
tableConfig.getIndexingConfig().getSegmentPartitionConfig();
Review comment:
Correct. In order to use partitioned replica-group assignment,
`ReplicaGroupStrategyConfig` is still required. We cannot directly take
`SegmentPartitionConfig` because in certain scenarios, user might not want to
use partitioned replica-group assignment even if segments are partitioned.
Closing the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
