richardstartin commented on a change in pull request #8124:
URL: https://github.com/apache/pinot/pull/8124#discussion_r799735990
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/request/context/FunctionContext.java
##########
@@ -84,7 +84,7 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- return Objects.hash(_type, _functionName, _arguments);
+ return 31 * 31 * _type.hashCode() + 31 * _functionName.hashCode() +
_arguments.hashCode();
Review comment:
Fortunately we don’t- the frames for ArrayList are in the flame graph
above. After this change, that whole stack trace disappears from allocation
profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
