mcvsubbu commented on a change in pull request #8078:
URL: https://github.com/apache/pinot/pull/8078#discussion_r799902991
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
##########
@@ -102,6 +104,22 @@ public void setRetentionTimeValue(String
retentionTimeValue) {
_retentionTimeValue = retentionTimeValue;
}
+ public String getDeletedSegmentRetentionTimeUnit() {
Review comment:
In an installation-free world, that will be a nice thing to do. But many
of us are running live installations of Pinot now. So, let us not change
existing configurations casually. We can migrate the existing configrations to
a new method, but this i s not the PR to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
