richardstartin commented on a change in pull request #8118:
URL: https://github.com/apache/pinot/pull/8118#discussion_r800048402
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimestampUtils.java
##########
@@ -19,19 +19,27 @@
package org.apache.pinot.spi.utils;
import java.sql.Timestamp;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
public class TimestampUtils {
+
+ private static final String[] SDF_FORMATS = {
Review comment:
Unless I’m mistaken, SDF is not thread safe which is why it was common
to store them in thread locals pre ZDK8. Using DateTimeFormatter should help if
you’re concerned about performance (but note that 2 exceptions have already
been thrown by now) because they can be shared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
