mayankshriv commented on a change in pull request #8138:
URL: https://github.com/apache/pinot/pull/8138#discussion_r800106075
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
##########
@@ -102,8 +104,9 @@ private TransformResultMetadata calculateResultMetadata() {
for (int i = 0; i < numThenStatements; i++) {
TransformFunction thenStatement = _elseThenStatements.get(i + 1);
TransformResultMetadata thenStatementResultMetadata =
thenStatement.getResultMetadata();
- Preconditions.checkState(thenStatementResultMetadata.isSingleValue(),
- String.format("Unsupported multi-value expression in the THEN clause
of index: %d", i));
+ if (!thenStatementResultMetadata.isSingleValue()) {
Review comment:
Probably to avoid `String.format` being evaluated unnecessarily?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
