siddharthteotia commented on a change in pull request #8139:
URL: https://github.com/apache/pinot/pull/8139#discussion_r800297874
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxAggregationFunction.java
##########
@@ -54,13 +54,39 @@ public GroupByResultHolder createGroupByResultHolder(int
initialCapacity, int ma
@Override
public void aggregate(int length, AggregationResultHolder
aggregationResultHolder,
Map<ExpressionContext, BlockValSet> blockValSetMap) {
- double[] valueArray = blockValSetMap.get(_expression).getDoubleValuesSV();
double max = aggregationResultHolder.getDoubleResult();
- for (int i = 0; i < length; i++) {
- double value = valueArray[i];
- if (value > max) {
- max = value;
+ BlockValSet blockValSet = blockValSetMap.get(_expression);
Review comment:
Thanks for sharing perf numbers, @richardstartin. I was also curious to
see the disassembled code as you said auto-vectorization probability increases
with continuing to treat as long. Please share if you have.
I am good with the PR. Please also check-in the benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
