richardstartin commented on pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#issuecomment-1032022397
@Jackie-Jiang here are some numbers for the query I was tuning (on my
MacBook so incomparable to numbers on different PRs)
master
```
Benchmark
(_intBaseValue) (_numRows) Mode Cnt Score Error
Units
BenchmarkFilteredAggregations.testNonFilteredAggregations
0 1500000 avgt 5 32506.601 ± 4192.330
us/op
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.alloc.rate
0 1500000 avgt 5 22.952 ± 2.747
MB/sec
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.alloc.rate.norm
0 1500000 avgt 5 1171670.000 ± 15616.821
B/op
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.churn.G1_Eden_Space
0 1500000 avgt 5 37.526 ± 323.107
MB/sec
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.churn.G1_Eden_Space.norm
0 1500000 avgt 5 1914496.826 ± 16484395.047 B/op
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.churn.G1_Old_Gen
0 1500000 avgt 5 7.749 ± 66.725
MB/sec
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.churn.G1_Old_Gen.norm
0 1500000 avgt 5 395366.090 ± 3404221.273 B/op
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.count
0 1500000 avgt 5 1.000
counts
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.time
0 1500000 avgt 5 13.000
ms
```
branch
```
Benchmark
(_intBaseValue) (_numRows) Mode Cnt Score Error Units
BenchmarkFilteredAggregations.testNonFilteredAggregations
0 1500000 avgt 5 28881.564 ± 2888.988 us/op
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.alloc.rate
0 1500000 avgt 5 20.376 ± 1.846 MB/sec
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.alloc.rate.norm
0 1500000 avgt 5 922164.440 ± 30175.150 B/op
BenchmarkFilteredAggregations.testNonFilteredAggregations:·gc.count
0 1500000 avgt 5 ≈ 0 counts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]