snleee commented on a change in pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#discussion_r802070938
##########
File path:
pinot-plugins/pinot-file-system/pinot-hdfs/src/main/java/org/apache/pinot/plugin/filesystem/HadoopPinotFS.java
##########
@@ -196,9 +199,21 @@ public void copyToLocalFile(URI srcUri, File dstFile)
@Override
public void copyFromLocalFile(File srcFile, URI dstUri)
throws Exception {
+ if (srcFile.isDirectory()) {
+ throw new IllegalArgumentException(srcFile.getAbsolutePath() + " is a
direactory");
+ }
_hadoopFS.copyFromLocalFile(new Path(srcFile.toURI()), new Path(dstUri));
}
+ public void copyFromLocalDir(File srcFile, URI dstUri)
Review comment:
extra space
##########
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/filesystem/LocalPinotFSTest.java
##########
@@ -205,41 +205,12 @@ public void testFS()
// Expected.
}
- // Check that directory only copy worked
Review comment:
Can we add the test for `copyFromLocalDir()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
