richardstartin commented on a change in pull request #8189:
URL: https://github.com/apache/pinot/pull/8189#discussion_r804659216
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java
##########
@@ -229,16 +235,11 @@ private static boolean
isFitForMetadataBasedPlan(AggregationFunction[] aggregati
/**
* Returns {@code true} if the given aggregations can be solved with
dictionary, {@code false} otherwise.
- * <p>Aggregations supported: MIN, MAX, MIN_MAX_RANGE, DISTINCT_COUNT,
SEGMENT_PARTITIONED_DISTINCT_COUNT
*/
private static boolean isFitForDictionaryBasedPlan(AggregationFunction[]
aggregationFunctions,
IndexSegment indexSegment) {
for (AggregationFunction aggregationFunction : aggregationFunctions) {
- AggregationFunctionType functionType = aggregationFunction.getType();
- if (functionType != AggregationFunctionType.MIN && functionType !=
AggregationFunctionType.MAX
- && functionType != AggregationFunctionType.MINMAXRANGE
- && functionType != AggregationFunctionType.DISTINCTCOUNT
- && functionType !=
AggregationFunctionType.SEGMENTPARTITIONEDDISTINCTCOUNT) {
+ if (!DICTIONARY_BASED_FUNCTIONS.contains(aggregationFunction.getType()))
{
Review comment:
+1, I made the same change on a local branch 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
