atris commented on a change in pull request #8148: URL: https://github.com/apache/pinot/pull/8148#discussion_r805614108
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java ########## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.dociditerators; + +import org.apache.pinot.core.common.BlockDocIdIterator; +import org.apache.pinot.segment.spi.Constants; + + +/** + * The iterator performs a linear pass through the underlying child iterator and returns + * the complement of the result set. + */ +public class NotDocIdIterator implements BlockDocIdIterator { + private BlockDocIdIterator _childDocIdIterator; + private int _lowerLimit; + private int _upperLimit; + private int _numDocs; + + public NotDocIdIterator(BlockDocIdIterator childDocIdIterator, int numDocs) { + _childDocIdIterator = childDocIdIterator; + _lowerLimit = 0; + + int currentDocIdFromChildIterator = childDocIdIterator.next(); + _upperLimit = currentDocIdFromChildIterator == Constants.EOF ? numDocs : currentDocIdFromChildIterator; + _numDocs = numDocs; + } + + @Override + public int next() { + while (_lowerLimit == _upperLimit) { + _lowerLimit = _upperLimit + 1; + + int nextMatchingDocId = _childDocIdIterator.next(); + + if (nextMatchingDocId == Constants.EOF) { + _upperLimit = _numDocs; + } else { + _upperLimit = nextMatchingDocId; + } + } + + if (_lowerLimit >= _numDocs) { + return Constants.EOF; + } + + return _lowerLimit++; + } + + @Override + public int advance(int targetDocId) { + if (targetDocId == Constants.EOF || targetDocId > _numDocs) { Review comment: Not sure if that is valid -- doing that causes tests in NotDocIteratorTest to fail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
