walterddr commented on pull request #8200: URL: https://github.com/apache/pinot/pull/8200#issuecomment-1039423995
> You can try the `copyFromLocalDir` API which is also introduced in the same previous PR, so that you don't need to change the current API in PinotFS. > > https://github.com/apache/pinot/blob/1382d293236d40e80d1652729fdb1632f92f7e48/pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java#L161 Yes I notices that change in #8162, but I don't think this works for 2 reasons. - currently S3PinotFS does a remote-to-remote recursive copy, so it will be very inefficient to download it to local and then reupload it to S3 - even if we want to go down this inefficient path, there's no recursive copyToLocalDir API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
