Jackie-Jiang commented on a change in pull request #8196:
URL: https://github.com/apache/pinot/pull/8196#discussion_r806191088
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -341,6 +342,10 @@ private BrokerResponseNative handleSQLRequest(long
requestId, String query, Json
return BrokerResponseNative.NO_TABLE_RESULT;
}
+ if (isDisableGroovy(realtimeTableConfig, offlineTableConfig)) {
Review comment:
Only check the table config when that table is actually queried
```suggestion
if (isDisableGroovy(offlineTableName != null ? offlineTableConfig: null,
realtimeTableName != null ? realtimeTableConfig: null)) {
```
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1174,6 +1179,26 @@ private static void handleHLLLog2mOverride(PinotQuery
pinotQuery, int hllLog2mOv
}
}
+ private boolean isDisableGroovy(@Nullable TableConfig realtimeTableConfig,
@Nullable TableConfig offlineTableConfig) {
Review comment:
(minor) Shall we put `offlineTableConfig` in front of
`realtimeTableConfig`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
