walterddr commented on pull request #8209:
URL: https://github.com/apache/pinot/pull/8209#issuecomment-1042160713


   > The logic in the `stateless` test is slightly different, where it actually 
tests the tenant behavior with fake brokers and servers which doesn't apply to 
the segment upload where real server might be required (even thought it might 
not be tested). I'd suggest keeping the test unmoved to limit the change and 
see if changing timeout fixes the issue.
   
   sounds good. 
   although i still think the test should be stateless, for one it is not 
suppose to test against server/broker logic in pinot-controller module which it 
does in the stateful test class; also it worked perfectly in stateless test.
   however given we don't have a test to cover the lineage logic in 
broker/server separately. i would agree to keep the current behavior (though it 
is much slower)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to