xiangfu0 commented on a change in pull request #8227:
URL: https://github.com/apache/pinot/pull/8227#discussion_r810278767
##########
File path: docker/images/pinot/Dockerfile
##########
@@ -79,6 +79,9 @@ COPY bin ${PINOT_HOME}/bin
COPY etc ${PINOT_HOME}/etc
COPY examples ${PINOT_HOME}/examples
+RUN wget -O ${PINOT_HOME}/etc/jmx_prometheus_javaagent-0.16.1.jar
https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.16.1/jmx_prometheus_javaagent-0.16.1.jar
&& \
Review comment:
For backward compatibility, can we also download javaagent-0.12.0 as
well?
So users on the latest image won't fail suddenly during restart.
##########
File path: docker/images/pinot/Dockerfile
##########
@@ -79,6 +79,9 @@ COPY bin ${PINOT_HOME}/bin
COPY etc ${PINOT_HOME}/etc
COPY examples ${PINOT_HOME}/examples
+RUN wget -O ${PINOT_HOME}/etc/jmx_prometheus_javaagent-0.16.1.jar
https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.16.1/jmx_prometheus_javaagent-0.16.1.jar
&& \
Review comment:
For backward compatibility, can we also download javaagent-0.12.0 jar?
So users on the latest image won't fail suddenly during restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
