Jackie-Jiang commented on a change in pull request #8230:
URL: https://github.com/apache/pinot/pull/8230#discussion_r810363465
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentConfig.java
##########
@@ -72,15 +81,21 @@ public Builder setSegmentNamePrefix(String
segmentNamePrefix) {
return this;
}
+ public Builder setSegmentNamePostfix(String segmentNamePostfix) {
+ _segmentNamePostfix = segmentNamePostfix;
+ return this;
+ }
+
public SegmentConfig build() {
Preconditions.checkState(_maxNumRecordsPerSegment > 0, "Max num records
per segment must be > 0");
- return new SegmentConfig(_maxNumRecordsPerSegment, _segmentNamePrefix);
+ return new SegmentConfig(_maxNumRecordsPerSegment, _segmentNamePrefix,
_segmentNamePostfix);
}
}
@Override
public String toString() {
- return "SegmentConfig{" + "_maxNumRecordsPerSegment=" +
_maxNumRecordsPerSegment + ", _segmentNamePrefix='"
- + _segmentNamePrefix + '\'' + '}';
+ return String
Review comment:
(minor) The current one is auto-generated. Not sure if you want to keep
it auto-generated (simply remove the current one and type `toString()` and IDE
will suggest the auto-generated one)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
