walterddr commented on a change in pull request #8200:
URL: https://github.com/apache/pinot/pull/8200#discussion_r810379327
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java
##########
@@ -88,10 +88,25 @@ boolean move(URI srcUri, URI dstUri, boolean overwrite)
throws IOException;
/**
- * Does the actual behavior of move in each FS.
+ * Copies the file from the src to dst. The original file is retained. If
the dst has parent directories
Review comment:
no this is actually true for file. which part is not true in the javadoc?
- if parent directory not exist it **should** create it when copy
- if exist it **should** overwrite
- we do recommend full path even for file copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
