kmozaid commented on a change in pull request #8224:
URL: https://github.com/apache/pinot/pull/8224#discussion_r814430680
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/PartitionFunctionFactory.java
##########
@@ -60,13 +60,15 @@ private PartitionFunctionFactory() {
*
* @param functionName Name of partition function
* @param numPartitions Number of partitions.
+ * @param functionConfig The function configuration for given function.
* @return Partition function
*/
// TODO: introduce a way to inject custom partition function
// a custom partition function could be used in the realtime stream
partitioning or offline segment partitioning.
// The PartitionFunctionFactory should be able to support these default
implementations, as well as instantiate
// based on config
- public static PartitionFunction getPartitionFunction(String functionName,
int numPartitions) {
+ public static PartitionFunction getPartitionFunction(String functionName,
int numPartitions,
+ Map<String, String>
functionConfig) {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
