Jackie-Jiang commented on a change in pull request #8263:
URL: https://github.com/apache/pinot/pull/8263#discussion_r816200009
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/SelectionPlanNode.java
##########
@@ -101,14 +103,12 @@ public SelectionPlanNode(IndexSegment indexSegment,
QueryContext queryContext) {
* @return true is all columns in order by clause are sorted . False
otherwise
*/
private boolean isAllOrderByColumnsSorted(List<OrderByExpressionContext>
orderByExpressions) {
- int numOrderByExpressions = orderByExpressions.size();
- for (int i = 0; i < numOrderByExpressions; i++) {
- OrderByExpressionContext expressionContext = orderByExpressions.get(0);
Review comment:
`orderByExpressions.get(0)` is wrong, and can cause false positive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
