xiangfu0 commented on a change in pull request #8266:
URL: https://github.com/apache/pinot/pull/8266#discussion_r817103344
##########
File path: pinot-plugins/pinot-input-format/pinot-avro/pom.xml
##########
@@ -37,15 +37,6 @@
<phase.prop>package</phase.prop>
</properties>
- <profiles>
Review comment:
right, so for any dependencies that presto is depending on, we need to
make those have a jdk8 version.
For module like `pinot-avro-base`, it's not required the compile
dependencies of presto-pinot-driver but only test dependency, so this time I
don't include them.
<img width="608" alt="image"
src="https://user-images.githubusercontent.com/1202120/156240819-179238bb-0f49-4569-9d13-c766d3a69d75.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1202120/156240819-179238bb-0f49-4569-9d13-c766d3a69d75.png"](https://user-images.githubusercontent.com/1202120/156240819-179238bb-0f49-4569-9d13-c766d3a69d75.png"){kind=link}