richardstartin commented on a change in pull request #8341:
URL: https://github.com/apache/pinot/pull/8341#discussion_r825410980
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -708,12 +708,12 @@ private static Expression
compileFunctionExpression(SqlBasicCall functionNode) {
case OTHER:
case OTHER_FUNCTION:
case DOT:
- functionName = functionNode.getOperator().getName().toUpperCase();
+ functionName = canonicalize(functionNode.getOperator().getName());
Review comment:
It’s not really a case of it being a bottleneck but a death by 1000 cuts
in this area, no single improvement will be transformative, but processing sql
allocates a lot which leads to a lot of CPU time spent on GC, if not much
latency impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
