KKcorps commented on a change in pull request #8304:
URL: https://github.com/apache/pinot/pull/8304#discussion_r825792598
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java
##########
@@ -273,9 +274,23 @@ public static String toDateTime(long millis, String
pattern, String timezoneId)
*/
@ScalarFunction
public static long fromDateTime(String dateTimeString, String pattern) {
+ if (StringUtils.isEmpty(dateTimeString)) {
Review comment:
Because of Tableau. Suppose a file as date time strings, but some of
those values are NULL. since pinot doesn't support NULL, we store them as empty
strings.
When someone applies a date transform function on such a column, an error is
thrown.
However, the behavious should be a default value returned in those cases (or
an explicit NULL value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
