Jackie-Jiang commented on a change in pull request #8337:
URL: https://github.com/apache/pinot/pull/8337#discussion_r826191908
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java
##########
@@ -290,4 +292,11 @@ private void submitSegmentGenTask(File localTempDir, URI
inputFileURI, int seqId
}
});
}
+
+ private File createLocalInputDateFile(URI inputFileURI, File
localInputTempDir) {
+ String inputFileURIPath = inputFileURI.getPath();
+ String fileNameFriendlyPath = UUID.randomUUID().toString();
+ File localInputFileDir = new File(localInputTempDir, fileNameFriendlyPath);
Review comment:
(minor) shall we rename the variable name since it doesn't have relation
to file name? Maybe inline it?
```suggestion
File localInputFileDir = new File(localInputTempDir,
UUID.randomUUID().toString());
```
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java
##########
@@ -238,7 +238,9 @@ private void submitSegmentGenTask(File localTempDir, URI
inputFileURI, int seqId
FileUtils.forceMkdir(localOutputTempDir);
//copy input path to local
- File localInputDataFile = new File(localInputTempDir, new
File(inputFileURI.getPath()).getName());
+ File localInputDataFile = createLocalInputDateFile(inputFileURI,
localInputTempDir);
+ System.out.println("localInputDataFile = " + localInputDataFile);
Review comment:
Avoid system output (is this debugging code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
