Jackie-Jiang commented on a change in pull request #8350:
URL: https://github.com/apache/pinot/pull/8350#discussion_r826466948
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java
##########
@@ -94,14 +93,14 @@ public void build(@Nullable SegmentVersion segmentVersion,
ServerMetrics serverM
}
if (_noDictionaryColumns != null) {
genConfig.setRawIndexCreationColumns(_noDictionaryColumns);
- Map<String, ChunkCompressionType> columnToCompressionType = new
HashMap<>();
for (String column : _noDictionaryColumns) {
FieldSpec fieldSpec = _dataSchema.getFieldSpecFor(column);
+ // Compression type is already configured in the constructor of
genConfig.
+ // Only update metrics compression type.
if (fieldSpec.getFieldType().equals(FieldSpec.FieldType.METRIC)) {
- columnToCompressionType.put(column,
ChunkCompressionType.PASS_THROUGH);
+ genConfig.setRawIndexCompressionType(column,
ChunkCompressionType.PASS_THROUGH);
}
}
Review comment:
Yes. We should not blindly override all metric compression to
PASS_THROUGH even if it is explicitly configured differently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
