Jackie-Jiang commented on a change in pull request #8351:
URL: https://github.com/apache/pinot/pull/8351#discussion_r827265605
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java
##########
@@ -58,9 +58,12 @@
@SuppressWarnings("rawtypes")
public class AggregationPlanNode implements PlanNode {
private static final EnumSet<AggregationFunctionType>
DICTIONARY_BASED_FUNCTIONS =
- EnumSet.of(AggregationFunctionType.MIN, AggregationFunctionType.MAX,
AggregationFunctionType.MINMAXRANGE,
- AggregationFunctionType.DISTINCTCOUNT,
AggregationFunctionType.SEGMENTPARTITIONEDDISTINCTCOUNT,
- AggregationFunctionType.DISTINCTCOUNTSMARTHLL);
+ EnumSet.of(AggregationFunctionType.MIN, AggregationFunctionType.MINMV,
AggregationFunctionType.MAX,
+ AggregationFunctionType.MAXMV, AggregationFunctionType.MINMAXRANGE,
AggregationFunctionType.MINMAXRANGEMV,
+ AggregationFunctionType.DISTINCTCOUNT,
AggregationFunctionType.DISTINCTCOUNTMV,
+ AggregationFunctionType.DISTINCTCOUNTHLL,
AggregationFunctionType.DISTINCTCOUNTHLLMV,
+ AggregationFunctionType.DISTINCTCOUNTRAWHLL,
AggregationFunctionType.DISTINCTCOUNTRAWHLLMV,
+ AggregationFunctionType.SEGMENTPARTITIONEDDISTINCTCOUNT,
AggregationFunctionType.DISTINCTCOUNTSMARTHLL);
Review comment:
Reverted this change as it violates our checkstyle rules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
