Jackie-Jiang commented on a change in pull request #8364:
URL: https://github.com/apache/pinot/pull/8364#discussion_r830269326
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##########
@@ -58,10 +61,9 @@
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
-import static
org.apache.pinot.core.data.manager.realtime.Fixtures.MAX_ROWS_IN_SEGMENT;
-import static
org.apache.pinot.core.data.manager.realtime.Fixtures.MAX_TIME_FOR_SEGMENT_CLOSE_MS;
-import static
org.apache.pinot.core.data.manager.realtime.Fixtures.createSchema;
-import static
org.apache.pinot.core.data.manager.realtime.Fixtures.createTableConfig;
+import static
org.apache.pinot.segment.local.segment.creator.Fixtures.MAX_ROWS_IN_SEGMENT;
+import static
org.apache.pinot.segment.local.segment.creator.Fixtures.MAX_TIME_FOR_SEGMENT_CLOSE_MS;
+import static
org.apache.pinot.segment.local.segment.creator.Fixtures.createSchema;
Review comment:
（minor) Removing the static import (especially the function)
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/TransformPipeline.java
##########
@@ -38,6 +38,10 @@
private final RecordTransformer _recordTransformer;
private final ComplexTypeTransformer _complexTypeTransformer;
+ public TransformPipeline(RecordTransformer recordTransformer,
ComplexTypeTransformer complexTypeTransformer) {
Review comment:
Add some javadoc, and also annotate `complexTypeTransformer` as
`Nullable`
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/TransformPipeline.java
##########
@@ -38,6 +38,10 @@
private final RecordTransformer _recordTransformer;
private final ComplexTypeTransformer _complexTypeTransformer;
+ public TransformPipeline(RecordTransformer recordTransformer,
ComplexTypeTransformer complexTypeTransformer) {
+ _recordTransformer = recordTransformer;
+ _complexTypeTransformer = complexTypeTransformer;
+ }
Review comment:
(minor) Add an empty line after this
##########
File path:
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/TransformPipelineTest.java
##########
@@ -25,18 +25,16 @@
import org.testng.Assert;
import org.testng.annotations.Test;
-import static org.apache.pinot.core.data.manager.realtime.Fixtures.*;
Review comment:
I'd suggest removing the static import especially on function usage
though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
