siddharthteotia commented on a change in pull request #8378:
URL: https://github.com/apache/pinot/pull/8378#discussion_r831632421
##########
File path:
pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java
##########
@@ -94,6 +94,15 @@ public void testLiteralOnlyTransformBrokerRequestFromSQL() {
.compileToPinotQuery("SELECT ago('PT1H'), fromDateTime('2020-01-01
UTC', 'yyyy-MM-dd z') FROM myTable")));
Assert.assertFalse(BaseBrokerRequestHandler
.isLiteralOnlyQuery(CalciteSqlParser.compileToPinotQuery("SELECT
count(*) from foo where bar > ago('PT1H')")));
+
Assert.assertTrue(BaseBrokerRequestHandler.isLiteralOnlyQuery(CalciteSqlParser
Review comment:
Should we not use full URLs as inputs to encodeUrl / decodeUrl functions
in tests ? From user perspective, they will use the full URL right ?
`SELECT encodeUrl(<myURL>) FROM FOO .....`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
