nizarhejazi commented on a change in pull request #8382:
URL: https://github.com/apache/pinot/pull/8382#discussion_r832713248
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java
##########
@@ -247,7 +247,7 @@ public static Timestamp toTimestamp(long millis) {
/**
* Converts Timestamp to epoch millis
*/
- @ScalarFunction
Review comment:
@Jackie-Jiang `fromTimestamp` takes Timestamp (object) that can be null
but cannot handle null (returns primitive long). Btw, I see `fromTimestamp` is
not being used so I removed the added annotation.
I applied the same logic to other functions: `ago`, `timezoneHour`,
`timezoneMinute` and `dateTimeConvert`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
