npawar commented on a change in pull request #8389:
URL: https://github.com/apache/pinot/pull/8389#discussion_r833584753
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
##########
@@ -504,7 +504,7 @@ private static void validateTierConfigList(@Nullable
List<TierConfig> tierConfig
segmentSelectorType, tierName);
Preconditions.checkState(TimeUtils.isPeriodValid(segmentAge),
"segmentAge: %s must be a valid period string (eg. 30d, 24h) in
tier: %s", segmentAge, tierName);
- } else {
+ } else if
(!segmentSelectorType.equalsIgnoreCase(TierFactory.FIXED_SEGMENT_SELECTOR_TYPE))
{
Review comment:
i left this one on purpose.. wanted users to have the flexibility to
remove the list if needed, without having to remove the whole tierConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
