Jackie-Jiang commented on a change in pull request #8358:
URL: https://github.com/apache/pinot/pull/8358#discussion_r834817821
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java
##########
@@ -198,6 +217,9 @@ private void updateSegmentMetrics(String tableNameWithType,
Context context) {
// Push is not finished yet, skip the segment
continue;
}
+ if (segmentZKMetadata != null && segmentZKMetadata.getSizeInBytes() > 0)
{
Review comment:
(minor) Store `segmentZKMetadata.getSizeInBytes()` in a local variable
to avoid reading the same field twice
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java
##########
@@ -88,7 +95,10 @@
DROPPED_MINION_INSTANCES("droppedMinionInstances", true),
// Number of online minion instances
- ONLINE_MINION_INSTANCES("onlineMinionInstances", true);
+ ONLINE_MINION_INSTANCES("onlineMinionInstances", true),
+
+ // Total size of compressed segments per table
Review comment:
(minor) Move this next to `TABLE_SIZE_PER_REPLICA_ON_SERVER`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
