amrishlal opened a new pull request #8413:
URL: https://github.com/apache/pinot/pull/8413
## Description
This PR allows for having column names in Pinot that have same name as the
corresponding column name in an incoming online or offline (avro) dataset even
after applying an Ingestion Transform Function. To do this, we modify
`ExpressionTransformer.topologicalSort` function so that Ingestion Transform
function dependency is not considered cyclic if an Ingestion Transform Function
has the same column name as both source and sink:
```
"transformConfigs": [{
"columnName": "jsonColumn",
"transformFunction": "JSON_FORMAT(jsonColumn)"
}]
```
Note that there is no actual cyclic dependency here since the function can
still be safely evaluated without getting into an infinite loop.
* `ExpressionTransformer.java` has changes to allow for specifying Ingestion
Transform functions where source and sink column names are the same.
* `ExpressionTransformTest.java` has unit tests for validating the change.
* `JsonIngestionFromAvroQueriesTest.java` was added as a real usecase
testcase. This test involves ingesting avro complex type fields into JSON
column when an Ingestion Transform function is used to map the avro complex
type field to Pinot JSON column of the same name.
* `AvroIngestionSchemaValidator.java` changes allow for validating type
compatibility between Avro complex type fields and JSON column.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to
the documentation as well.
See
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
