walterddr commented on a change in pull request #8390:
URL: https://github.com/apache/pinot/pull/8390#discussion_r836979769



##########
File path: 
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerStatelessTest.java
##########
@@ -163,6 +163,8 @@ public void testPinotTaskManagerSchedulerWithRestart()
     // Restart controller
     stopController();
     startController(properties);
+    // wait for controller to start correctly.
+    Thread.sleep(1000);

Review comment:
       this I have no idea. the error simply said
   ```
   Mar 28, 2022 6:31:51 PM org.glassfish.grizzly.http.server.NetworkListener 
shutdownNow
   INFO: Stopped listener bound to [0.0.0.0:18998]
   Mar 28, 2022 6:31:52 PM org.glassfish.grizzly.http.server.NetworkListener 
start
   INFO: Started listener bound to [0.0.0.0:18998]
   Mar 28, 2022 6:31:52 PM org.glassfish.grizzly.http.server.HttpServer start
   INFO: [HttpServer-1] Started.
   
   org.apache.http.NoHttpResponseException: localhost:18998 failed to respond
   
        at 
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:141)
        at 
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
        at 
org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
        at 
org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
        at 
org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:157)
        at 
org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
        at 
org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
        at 
org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
        at 
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
        at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
        at 
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
        at 
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
   ...
        at 
org.apache.pinot.common.utils.http.HttpClient.sendJsonPutRequest(HttpClient.java:257)
        at 
org.apache.pinot.controller.helix.ControllerRequestClient.updateTableConfig(ControllerRequestClient.java:100)
        at 
org.apache.pinot.controller.helix.ControllerTest.updateTableConfig(ControllerTest.java:540)
        at 
org.apache.pinot.controller.helix.core.minion.PinotTaskManagerStatelessTest.testPinotTaskManagerSchedulerWithRestart(PinotTaskManagerStatelessTest.java:180)
   ```
   we should separately investigate the issue IMO




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to