Jackie-Jiang commented on a change in pull request #8369:
URL: https://github.com/apache/pinot/pull/8369#discussion_r837876217
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java
##########
@@ -75,6 +81,11 @@ public FilterConfig getFilterConfig() {
return _filterConfig;
}
+ @Nullable
+ public List<AggregationConfig> getAggregationConfigs() {
Review comment:
(minor) Move this after `getTransformConfigs()`
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java
##########
@@ -44,18 +45,23 @@
@JsonPropertyDescription("Configs related to record transformation functions
applied during ingestion")
private final List<TransformConfig> _transformConfigs;
+ @JsonPropertyDescription("Configs related to record aggregation function
applied during ingestion")
+ private final List<AggregationConfig> _aggregationConfigs;
+
@JsonPropertyDescription("Config related to handling complex type")
private final ComplexTypeConfig _complexTypeConfig;
@JsonCreator
public IngestionConfig(@JsonProperty("batchIngestionConfig") @Nullable
BatchIngestionConfig batchIngestionConfig,
@JsonProperty("streamIngestionConfig") @Nullable StreamIngestionConfig
streamIngestionConfig,
@JsonProperty("filterConfig") @Nullable FilterConfig filterConfig,
+ @JsonProperty("aggregationConfigs") @Nullable List<AggregationConfig>
aggregationConfigs,
Review comment:
(minor) Move this after `transformConfigs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
