INNOCENT-BOY commented on a change in pull request #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r838639689
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/AllowAllAccessControlFactory.java
##########
@@ -34,6 +36,10 @@ public AllowAllAccessControlFactory() {
public void init(PinotConfiguration configuration) {
}
+ public void init(ZkHelixPropertyStore<ZNRecord> propertyStore) {
+ }
+
+ @Override
Review comment:
@apucher Thanks for your suggestions. I have changed the signature of
the static loadFactory to include both configuration and property store.
Also I have reconstructed AccessControlFactory and relevant class about
Controller/Broker/Server. And introduce an init(PinotConfiguration,
ZkHelixPropertyStore) that defaults to invoking the legacy
init(PinotConfiguration) method Rather that using instanceof. Looking forward
your review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
