mcvsubbu commented on a change in pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#discussion_r838840404



##########
File path: 
compatibility-verifier/sample-test-suite/config/feature-test-3-realtime.json
##########
@@ -0,0 +1,63 @@
+{
+  "tableIndexConfig": {
+    "aggregateMetrics": false,
+    "autoGeneratedInvertedIndex": false,
+    "createInvertedIndexDuringSegmentGeneration": false,
+    "enableDefaultStarTree": false,
+    "enableDynamicStarTreeCreation": false,
+    "loadMode": "MMAP",
+    "noDictionaryColumns": ["stringDimSV2","intMetric1", "longMetric1", 
"floatMetric1", "doubleMetric1", "bytesMetric1"],
+    "nullHandlingEnabled": false,
+    "segmentFormatVersion": "v3",
+    "bloomFilterColumns": ["stringDimSV1"],
+    "rangeIndexColumns": ["doubleDimSV1"],
+    "rangeIndexVersion": 2,
+    "varLengthDictionaryColumns": ["stringDimSV1"],
+    "segmentPartitionConfig": {
+      "columnPartitionMap": {
+        "longDimSV1": {
+          "functionName": "Modulo",
+          "numPartitions": 3
+        }
+      }
+    },
+    "streamConfigs": {
+      "realtime.segment.flush.threshold.size": "63",
+      "realtime.segment.flush.threshold.time": "1h",
+      "streamType": "kafka",
+      "stream.kafka.topic.name": "PinotRealtimeFeatureTest3Event",
+      "stream.kafka.consumer.type": "simple",
+      "stream.kafka.decoder.class.name": 
"org.apache.pinot.plugin.stream.kafka.KafkaJSONMessageDecoder",
+      "stream.kafka.consumer.factory.class.name": 
"org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory",
+      "stream.kafka.broker.list": "localhost:19092",
+      "stream.kafka.zk.broker.url": "localhost:2181/kafka",
+      "stream.kafka.consumer.prop.auto.offset.reset": "largest"
+    }
+  },
+  "metadata": {
+    "customConfigs": {
+      "d2Name": ""
+    }
+  },
+  "segmentsConfig": {
+    "replicasPerPartition": "1",
+    "replication": "1",
+    "retentionTimeUnit": "",
+    "retentionTimeValue": "",
+    "schemaName": "FeatureTest3",
+    "segmentAssignmentStrategy": "BalanceNumSegmentAssignmentStrategy",
+    "segmentPushFrequency": "daily",
+    "segmentPushType": "APPEND",
+    "timeColumnName": "HoursSinceEpoch",
+    "timeType": "HOURS"
+  },
+  "quota": {

Review comment:
       Do we need QPS quota? We don't want to fail the test because of quota 
exceed (for whatever reason), so better to remove this.

##########
File path: compatibility-verifier/sample-test-suite/post-broker-rollback.yaml
##########
@@ -20,6 +20,12 @@
 # Operations to be done.
 description: Operations to be run after broker rollback
 operations:
+  - type: tableOp

Review comment:
       why are we creating this table again and again? We never stop zookeeper, 
so any table created once remains.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to