siddharthteotia commented on a change in pull request #8441:
URL: https://github.com/apache/pinot/pull/8441#discussion_r839028089
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java
##########
@@ -58,25 +60,37 @@
@JsonIgnoreProperties(ignoreUnknown = true)
public class InstancePartitions {
private static final char PARTITION_REPLICA_GROUP_SEPARATOR = '_';
+ private static final String PARTITIONS_KEY = "partitions";
+ private static final String INSTANCE_SEPARATOR = "/";
private final String _instancePartitionsName;
- private final Map<String, List<String>> _partitionToInstancesMap;
+ private final Map<String, List<String>>
_partitionWithReplicaGroupToInstancesMap;
+ private final Map<Integer, List<String>> _partitionToInstancesMap;
private int _numPartitions;
private int _numReplicaGroups;
public InstancePartitions(String instancePartitionsName) {
_instancePartitionsName = instancePartitionsName;
+ _partitionWithReplicaGroupToInstancesMap = new TreeMap<>();
_partitionToInstancesMap = new TreeMap<>();
}
@JsonCreator
private InstancePartitions(
@JsonProperty(value = "instancePartitionsName", required = true) String
instancePartitionsName,
- @JsonProperty(value = "partitionToInstancesMap", required = true)
- Map<String, List<String>> partitionToInstancesMap) {
+ @JsonProperty(value = "partitionWithReplicaGroupToInstancesMap",
required = true)
+ Map<String, List<String>> partitionWithReplicaGroupToInstancesMap,
+ @JsonProperty(value = "partitionToInstancesMap")
Review comment:
To get a better understanding of the new information in
InstancePartitions, can you update the PR description with an example of what
it looks like now ?
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java
##########
@@ -58,25 +60,37 @@
@JsonIgnoreProperties(ignoreUnknown = true)
public class InstancePartitions {
private static final char PARTITION_REPLICA_GROUP_SEPARATOR = '_';
+ private static final String PARTITIONS_KEY = "partitions";
+ private static final String INSTANCE_SEPARATOR = "/";
private final String _instancePartitionsName;
- private final Map<String, List<String>> _partitionToInstancesMap;
+ private final Map<String, List<String>>
_partitionWithReplicaGroupToInstancesMap;
+ private final Map<Integer, List<String>> _partitionToInstancesMap;
private int _numPartitions;
private int _numReplicaGroups;
public InstancePartitions(String instancePartitionsName) {
_instancePartitionsName = instancePartitionsName;
+ _partitionWithReplicaGroupToInstancesMap = new TreeMap<>();
_partitionToInstancesMap = new TreeMap<>();
}
@JsonCreator
private InstancePartitions(
@JsonProperty(value = "instancePartitionsName", required = true) String
instancePartitionsName,
- @JsonProperty(value = "partitionToInstancesMap", required = true)
- Map<String, List<String>> partitionToInstancesMap) {
+ @JsonProperty(value = "partitionWithReplicaGroupToInstancesMap",
required = true)
+ Map<String, List<String>> partitionWithReplicaGroupToInstancesMap,
+ @JsonProperty(value = "partitionToInstancesMap")
Review comment:
To get a better understanding of the new information in
`InstancePartitions`, can you update the PR description with an example of what
it looks like now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
