richardstartin commented on a change in pull request #8455:
URL: https://github.com/apache/pinot/pull/8455#discussion_r840333733
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1,30 +1,15 @@
-## Description
-<!-- Add a description of your PR here.
-A good description should include pointers to an issue or design document, etc.
--->
-## Upgrade Notes
-Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
-* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
-
-Does this PR fix a zero-downtime upgrade introduced earlier?
-* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
-
-Does this PR otherwise need attention when creating release notes? Things to
consider:
+Instructions:
+1. The PR has to be tagged with at least one of the following labels:
+ 1. `feature`
+ 2. `bugfix`
+ 3. `performance`
+ 4. `ui`
+ 5. `backward-incompat`
+ 6. `release-notes` (*)
+2. Remove these instructions before publishing the PR.
+
+(*) Use `release-notes` label for scenarios like:
Review comment:
Since it’s an Apache project contributors can’t apply the labels, so
it’s up to committers to do it, so “compulsory” might be off putting to first
time contributors. If the author is a committer they should do it, otherwise
the reviewer does it. It’s compulsory for committers, but that’s a small group
of people do it’s hard not to get the memo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
